Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Contact Journal Event/Risk extension (EXPOSUREAPP-5413) #2696

Merged
merged 42 commits into from
Mar 31, 2021
Merged

Contact Journal Event/Risk extension (EXPOSUREAPP-5413) #2696

merged 42 commits into from
Mar 31, 2021

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Mar 26, 2021 •
edited
Loading

DRAFT-PR for Exposureapp-5413. (Event Check-In UI: Contact Journal Event extension)

As a CWA user I want to if a risk was caused by attending an event, so that I can warn others attending the same event but do not use the CWA.

toDos: (done)

  • some layout/logic adjustments
  • check/adjust for latest techspec/r2.0 changes
  • string adjustments
  • adjustment of existing journal tests & new tests

Note (update):

How to test:

  • For final testing, risk event PRs have to be merged (see above)
  • For testing the UI in advance you can create an automatic screenshot e.g. (Screenshot attached)
  • check ContactDiaryOverviewViewModelTest, ContactDiaryDatabaseTest & ContactDiaryOverviewFragmentTest

Screenshot:

screen

@BMItr BMItr added the maintainers Tag pull requests created by maintainers label Mar 26, 2021
@BMItr BMItr added this to the 2.0.0 milestone Mar 26, 2021
@BMItr BMItr requested review from a team March 26, 2021 11:24
@BMItr BMItr marked this pull request as draft March 26, 2021 11:25
@ralfgehrer ralfgehrer added text change PRs with text changes. prio PRs to review first. labels Mar 29, 2021
@BMItr
Copy link
Contributor Author

BMItr commented Mar 31, 2021

@mtwalli adjusted params, strings, srcCompat etc.
Please approve or comment after conflict is solved later.

janetback
janetback previously approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

mtwalli
mtwalli previously approved these changes Mar 31, 2021
View reviewed changes
@BMItr BMItr dismissed stale reviews from mtwalli and janetback via 91602de March 31, 2021 14:05
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

44.0% 44.0% Coverage
0.0% 0.0% Duplication

@ralfgehrer ralfgehrer merged commit bc2764a into release/2.0.x Mar 31, 2021
@ralfgehrer ralfgehrer deleted the feature/5413-Contact-Journal-Event-Extension branch March 31, 2021 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chris-cwa chris-cwa chris-cwa approved these changes

@mtwalli mtwalli mtwalli approved these changes

@janetback janetback janetback left review comments

Assignees

@mtwalli mtwalli

@chris-cwa chris-cwa

Labels
maintainers Tag pull requests created by maintainers prio PRs to review first. text change PRs with text changes.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BMItr @mtwalli @janetback @chris-cwa @ralfgehrer @harambasicluka